Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: document LINE social sign-in provider #2006

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: document LINE social sign-in provider #2006

wants to merge 2 commits into from

Conversation

David-Wobrock
Copy link
Contributor

Document how to set up a LINE social sign-in.

Related Issue or Design Document

Relates to ory/kratos#4240

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@David-Wobrock David-Wobrock mentioned this pull request Jan 14, 2025
Open
7 tasks
@vinckr vinckr added the upstream Issue is caused by an upstream dependency. label Jan 14, 2025
@David-Wobrock David-Wobrock force-pushed the feat/document-line-social-signin branch from 08eea37 to 3234dbf Compare January 15, 2025 09:48
@David-Wobrock David-Wobrock requested a review from rach-r January 16, 2025 08:32
@David-Wobrock David-Wobrock force-pushed the feat/document-line-social-signin branch from 3234dbf to f3ab52c Compare January 20, 2025 13:45
@David-Wobrock David-Wobrock force-pushed the feat/document-line-social-signin branch from f3ab52c to 1dbe734 Compare January 22, 2025 10:24
@David-Wobrock
Copy link
Contributor Author

Thanks @vinckr for the patch 🙏

@David-Wobrock David-Wobrock force-pushed the feat/document-line-social-signin branch from d13c654 to f345a6e Compare January 28, 2025 12:55
vinckr
vinckr approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@David-Wobrock David-Wobrock force-pushed the feat/document-line-social-signin branch from f345a6e to e43bb18 Compare February 7, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinckr vinckr vinckr approved these changes

@rach-r rach-r rach-r approved these changes

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

Assignees
No one assigned
Labels
upstream Issue is caused by an upstream dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@David-Wobrock @vinckr @rach-r