Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: document FedCM #2017

Merged
merged 2 commits into from
Feb 5, 2025
Merged

feat: document FedCM #2017

merged 2 commits into from
Feb 5, 2025

Conversation

hperl
Copy link
Collaborator

@hperl hperl commented Jan 31, 2025

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@hperl hperl requested review from vinckr and aeneasr as code owners January 31, 2025 12:28
@hperl hperl requested a review from aeneasr January 31, 2025 12:28
@hperl hperl requested a review from piotrmsc January 31, 2025 12:28
@hperl hperl self-assigned this Jan 31, 2025
@hperl hperl enabled auto-merge (squash) February 3, 2025 14:21
@hperl hperl requested a review from christiannwamba February 5, 2025 08:51
@christiannwamba
Copy link
Contributor

Looks good to me.

Copy link
Collaborator

@piotrmsc piotrmsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minors but looking good :)

  1. Please add short description on why it might be useful for the users - provide example description like with content page.
  2. Check typos
  3. I think then CNAME should be some sort of callout as prerequisite

@hperl hperl merged commit 8092e60 into master Feb 5, 2025
9 checks passed
@hperl hperl deleted the hperl/fedcm branch February 5, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants