fix: transient_payload lost in API flow with session token exchange code (PS-482) #4112
+430
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
reviewed
Sep 19, 2024
| } | ||
| raw := gjson.GetBytes(flow.GetInternalContext(), internalContextTransientPayloadPath) | ||
| if !raw.IsObject() { | ||
| return nil, nil |
There was a problem hiding this comment.
Error is always nil, remove it?
| if err := flow.SetTransientPayloadIntoInternalContext(f, sqlxx.JSONRawMessage(p.TransientPayload)); err != nil { | ||
| return s.handleError(w, r, f, pid, nil, err) | ||
| } | ||
| if err := s.d.RegistrationFlowPersister().UpdateRegistrationFlow(ctx, f); err != nil { |
There was a problem hiding this comment.
Is this database write really needed?
This patch adds the ability to verify Android APK origins used during WebAuthn/Passkey exchange. Upgrades go-webauthn and includes fixes for Go 1.23 and workarounds for Swagger.
commit e4779e1 Author: splaunov <splaunov@gmail.com> Date: Tue Sep 17 13:49:38 2024 +0300 fix: transient_payload lost in API flow with session token exchange code (PS-482)
maoanran
force-pushed
the
feature/fix-ps-482
branch
from
e4779e1 to
91327fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting oidc api flow with session token exchange code, transient_payload data is lost.
This PR fixes this issue.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments