added validation for custom search engine url #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SentinelKnight
force-pushed
the
add-validations-for-custom-search-engine-url
branch
from
7697c06 to
954354f
Compare
ospfranco
requested changes
Apr 19, 2025
SentinelKnight
force-pushed
the
add-validations-for-custom-search-engine-url
branch
from
954354f to
4ca6512
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added validation to check for proper search engine url format and better error message when invalid search engine url used.
I need some help with checking the regex, used AI help for this and tested with few popular search engines and some invalid urls and it seems to work.