Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra '%' from LTI_DEFAULT_JUPYTER_HUB_URL #18

Merged

Conversation

Danyal-Faheem
Copy link
Contributor

Fixes the issue where Jupyter Xblock does not load when used with ENABLE_HTTPS=True.

Copy link
Collaborator

@Abdul-Muqadim-Arbisoft Abdul-Muqadim-Arbisoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Abdul-Muqadim-Arbisoft Abdul-Muqadim-Arbisoft merged commit aa3eacb into overhangio:release Dec 12, 2024
2 checks passed
@Danyal-Faheem Danyal-Faheem deleted the danyal/fix-base-url branch December 12, 2024 13:42
@regisb
Copy link
Contributor

regisb commented Dec 13, 2024

Please do make a release with this fix before Sumac is out, such that Redwood users have a working release in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants