Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove auto-add for PRs #1011

Merged

Conversation

DawoudSheraz
Copy link
Contributor

The auto-add for Issues and PRs was added in #978. However, it did not work as expected for PRs. It was failing on PRs created from fork and increasing the noise.
The reason was that when PRs were created from forks, the Personal access token from main repo was not passed. This results in GA not getting the appropriate auth token to auto-add the PR to the project. Additionally, the workflows on PR needed to be triggered manually (both auto-add and CI), thus keeping the manual intervention just like before.

@DawoudSheraz DawoudSheraz requested a review from regisb March 5, 2024 07:04
@regisb
Copy link
Contributor

regisb commented Mar 5, 2024

Note: this same PR was already applied to all plugins.

Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@regisb regisb merged commit f211b98 into overhangio:master Mar 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants