-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade: replace deprecated pkg_resources with importlib, resolves #966 #977
upgrade: replace deprecated pkg_resources with importlib, resolves #966 #977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Could you please just add a changelog entry? https://docs.tutor.overhang.io/tutor.html#contributing
Done. Thanks for reminding me once again. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Can you please rebase and squash your commits on top of master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks a lot! It looks like you still need to rebase your changes though.
I took the liberty to cherry-pick your commit and fix conflicts. This is now closed by d99b2fe |
@@ -1,7 +1,7 @@ | |||
# -*- mode: python -*- | |||
import importlib | |||
import os | |||
import pkg_resources | |||
from importlib_metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR, this line did cause an issue during the release. It was fixed by b69a8c7
Description:
This PR addresses the issue reported in Issue #966, where Tutor was facing compatibility problems with Python 3.12, particularly when using plugins. The root cause was identified as the continued use of the pkg_resources module, which is not available in Python 3.12 environments without explicit installation of setuptools.
Problem:
Solution:
Testing: