Mitigate arbitrary path write in uploader (GHSL-2024-182) #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen2345
approved these changes
Aug 12, 2024
texpert
force-pushed
the
mitigate-arbitrary-path-write-in-uploader
branch
from
03e94b3 to
69c0597
Compare
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks GHSL team member @p- for disovering and reporting this!
Arbitrary file write to RCE (GHSL-2024-182) vulnerability reported:
An arbitrary file write vulnerability accessible via the upload method of the
MediaControllerallows authenticated users to write arbitrary files to any location on the web server Camaleon CMS is running on (depending on the permissions of the underlying filesystem). E.g. This can lead to a delayed remote code execution in case an attacker is able to write a Ruby file into the config/initializers/ subfolder of the Ruby on Rails application.This PR fixes the vulnerability by introducing the
CamaleonCmsUploader.valid_folder_path?method which checks for directory traversal path, absolute file path, and URI-like path.