Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootstrap.min.css.map #1092

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Conversation

texpert
Copy link
Collaborator

@texpert texpert commented Aug 23, 2024

I remember someone was asking where is the sourcemap, so added.

Copy link
Collaborator

@brian-kephart brian-kephart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't worked much with source maps, so I'm not sure how to review this PR. Adding it seems like a good idea though. LMK if there's anything in particular to check.

@texpert
Copy link
Collaborator Author

texpert commented Aug 25, 2024

I haven't worked much with source maps, so I'm not sure how to review this PR. Adding it seems like a good idea though. LMK if there's anything in particular to check.

Thanks for approval, @brian-kephart!

Nothing to check in the PR - I have just checked if the map is precompiled into the assets and loaded into the browser.

It works OK in the development environment if the config.assets.debug = true is set.

As for production, I don't think it will work, because the sourcemap of the asset is failing to load, being required additionally in a theme - the browser is trying to load the sourcemap from a theme related path.

For debugging reasons, the config.assets.debug = true can be also set in production, see rails/sprockets#502 (comment).

@texpert texpert merged commit 52c56fb into owen2345:master Aug 25, 2024
16 checks passed
@texpert texpert deleted the add-bootstrap-min-css-map branch September 16, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants