Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updated_ajax action to permit only legit params #1109

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

texpert
Copy link
Collaborator

@texpert texpert commented Jan 13, 2025

No description provided.

@texpert texpert marked this pull request as draft January 13, 2025 02:54
Add `require 'pathname'` to the spec_helper.rb to avoid `Uninitialized Pathname constant` error

Use expect(response.body).to include('password_confirmation') to avoid errors caused by changes in responses on different Rails' versions
@texpert texpert marked this pull request as ready for review January 13, 2025 10:25
Copy link
Owner

@owen2345 owen2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@texpert texpert merged commit 179fd6b into owen2345:master Jan 14, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants