Frontend Docker Image #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for thallium canceled.
|
ChrisLovering
approved these changes
Aug 17, 2024
|
/merge |
|
✅ Successfully fast-forwarded commits from |
jchristgit
reviewed
Aug 17, 2024
Comment on lines
+7
to
+13
| try { | ||
| commitHash = child.execSync("git rev-parse --short HEAD") | ||
| .toString().replace(/\n$/, ""); | ||
| } catch (e) { | ||
| console.error("Failed to get commit hash"); | ||
| console.error(e); | ||
| } |
There was a problem hiding this comment.
FWIW, you can read .git/HEAD and then open the file linked in ref: $FILENAME to get the current commit hash without git.
There was a problem hiding this comment.
We have git, the problem is we build in the context of the thallium-frontend subdirectory of the monorepo, whilst the .git folder sits in the monorepo root, so we just do not have the .git folder in the build at all.
We can add handling down the line to read this value out of the git_sha build argument that we get passed in and do something like "test against git, try fetch git_sha arg, default to 'unknown'".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Docker image for running the development version of the frontend locally.
This spins up the Vite development server in a Docker container allowing for live-reloading with changes in the
thallium-frontenddirectory.Since we don't deploy the application with Docker, this is not an optimised image and runs with the development server (rather than some sort of static file hosting software with the built image).
If desired, it should still be possible to have the container eject a built version by running it with
pnpm run build, though this may be missing things such as git context which cannot be detected (we do not mount the .git folder in the root, only the subdirectory).