crates: move host CPUID queries from cpuid-gen to cpuid-utils

The `cpuid-gen` utility contains logic that reads and pretty-prints
bhyve's default CPUID values (or the host proecssor's raw CPUID
outputs). Move the logic that reads these values into the `cpuid-utils`
crate, re-express it in terms of `cpuid-utils`'s CPUID types, and make
`cpuid-gen` call the new logic. Future changes will make propolis-server
use this logic to set default CPUID values for VMs whose instance specs
contain no CPUID settings.

Fix a bit shifting bug in `collect_cpuid`'s handler for standard leaf D:
this leaf outputs 64-bit values across two output registers, and the old
logic wasn't shifting edx into the high 32 bits before OR'ing it with
its counterpart register.

Finally, simplify PHD's `cpuid_boot_test`: since it can now ask bhyve
for CPUID settings that bhyve thinks are valid, it no longer needs to
try to stitch together its own minimum viable CPUID profile. This test
now passes with a Windows Server 2022 guest.

bin/propolis-server/src/lib/initializer.rs

@@ -994,7 +994,7 @@ impl MachineInitializer<'_> {
         ) -> Option<CpuidValues> {
             let leaf = CpuidIdent::leaf(leaf);
             let Some(cpuid) = &spec.cpuid else {
-                return Some(cpuid_utils::host_query(leaf));
+                return Some(cpuid_utils::host::query(leaf));
             };
 
             cpuid.get(leaf).copied()

bin/propolis-standalone/src/main.rs

@@ -867,10 +867,10 @@ fn generate_smbios(params: SmbiosParams) -> anyhow::Result<smbios::TableBytes> {
         ..Default::default()
     };
 
-    let cpuid_vendor = cpuid_utils::host_query(CpuidIdent::leaf(0));
+    let cpuid_vendor = cpuid_utils::host::query(CpuidIdent::leaf(0));
     let cpuid_ident = params
         .cpuid_ident
-        .unwrap_or_else(|| cpuid_utils::host_query(CpuidIdent::leaf(1)));
+        .unwrap_or_else(|| cpuid_utils::host::query(CpuidIdent::leaf(1)));
     let family = match cpuid_ident.eax & 0xf00 {
         // If family ID is 0xf, extended family is added to it
         0xf00 => (cpuid_ident.eax >> 20 & 0xff) + 0xf,
@@ -894,13 +894,13 @@ fn generate_smbios(params: SmbiosParams) -> anyhow::Result<smbios::TableBytes> {
     };
     let proc_id = u64::from(cpuid_ident.eax) | u64::from(cpuid_ident.edx) << 32;
     let procname_entries = params.cpuid_procname.or_else(|| {
-        if cpuid_utils::host_query(CpuidIdent::leaf(0x8000_0000)).eax
+        if cpuid_utils::host::query(CpuidIdent::leaf(0x8000_0000)).eax
             >= 0x8000_0004
         {
             Some([
-                cpuid_utils::host_query(CpuidIdent::leaf(0x8000_0002)),
-                cpuid_utils::host_query(CpuidIdent::leaf(0x8000_0003)),
-                cpuid_utils::host_query(CpuidIdent::leaf(0x8000_0004)),
+                cpuid_utils::host::query(CpuidIdent::leaf(0x8000_0002)),
+                cpuid_utils::host::query(CpuidIdent::leaf(0x8000_0003)),
+                cpuid_utils::host::query(CpuidIdent::leaf(0x8000_0004)),
             ])
         } else {
             None

bin/propolis-utils/Cargo.toml

@@ -17,6 +17,7 @@ doctest = false
 [dependencies]
 anyhow.workspace = true
 clap = { workspace = true, features = ["derive"] }
+cpuid_utils = { workspace = true, features = ["instance-spec"] }
 serde = { workspace = true, features = ["derive"] }
 propolis = { workspace = true, default-features = false }
 propolis_api_types.workspace = true