Generate update set on conflict for upserts #145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upserting to tables with only key columns, typo would generate
do nothing
as a conflict resolution. This has the disadvantage of making the query not execute thereturning
part, which meant that in cases where an upsert was executed targeting a single row, no rows would return and the generated code would cause an error.As a workaround, we generate
update set k = excluded.k
for an arbitrary key column k instead. This causes thereturning
part of the query to run but shouldn't change the value of the row as typo sees it.update set
instead ofdo nothing