don't unregister cvars on shutdown as apparently that's broken (fixes #…

…19)
p0358 · Oct 23, 2024 · 9913578 · 9913578
1 parent 8207f03
commit 9913578
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/bmedll/ConCommandManager.cpp b/bmedll/ConCommandManager.cpp
@@ -75,7 +75,9 @@ void ConCommandManager::UnregisterAllCommands()
 ConCommandManager::~ConCommandManager()
 {
     SPDLOG_LOGGER_DEBUG(m_logger, "ConCommandManager destructor");
-    //if (!g_isShuttingDown)
+    // Note: ConVar/ConCommand unregistration doesn't work properly, they still appear in FactoryInternalIterator
+    // and can cause crashes on shutdown
+    if (!g_isShuttingDown)
         UnregisterAllCommands();
 }