Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ecosystem-independent all and none schemes #343

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

immqu
Copy link

@immqu immqu commented Nov 13, 2024

This PR introduces the possibility to specify all versions, or none, as suggested in #267 and implemented in aboutcode-org/univers#146

@immqu immqu changed the title add ecosystem-independent all and none scheme, fix some typos Introduce ecosystem-independent all and none schemes Nov 13, 2024
Copy link
Contributor

@tschmidtb51 tschmidtb51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments

Signed-off-by: Kunz, Immanuel <immanuel.kunz@aisec.fraunhofer.de>
Signed-off-by: Kunz, Immanuel <immanuel.kunz@aisec.fraunhofer.de>
Signed-off-by: Kunz, Immanuel <immanuel.kunz@aisec.fraunhofer.de>
Signed-off-by: Kunz, Immanuel <immanuel.kunz@aisec.fraunhofer.de>
Signed-off-by: Kunz, Immanuel <immanuel.kunz@aisec.fraunhofer.de>
@immqu immqu marked this pull request as ready for review December 2, 2024 08:18
@immqu
Copy link
Author

immqu commented Feb 27, 2025

@pombredanne can this PR be merged or are there any open points to discuss?

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please remove the unrelated changes to another PR for simplicity.

@immqu
Copy link
Author

immqu commented Mar 5, 2025

I have removed the sorting and will add it in another PR. It should be easily reviewable now.

@immqu immqu requested a review from pombredanne March 10, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants