Add error-prone rule for converting Stream to Iterator

[rynorris]

Before this PR

In certain cases (https://bugs.openjdk.org/browse/JDK-8267359) converting Stream to Iterator can cause the entire stream to be consumed eagerly. This has bitten us on multiple occasions, causing poor performance in otherwise innocuous code.

Catching the specific cases isn't easy, but just generally converting between the two iteration paradigms is a code smell and should be avoided where possible, so let's warn against it.

After this PR

==COMMIT_MSG==
Add error-prone rule for converting Stream to Iterator
==COMMIT_MSG==

[changelog-app]

Generate changelog in changelog/@unreleased

What do the change types mean?

• feature: A new feature of the service.
• improvement: An incremental improvement in the functionality or operation of the service.
• fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
• break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
  and external consumers of the service's API (e.g. customer-written software or integrations).
• deprecation: Advertises the intention to remove service functionality without any change to the
  operation of the service itself.
• manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
  performing database surgery, ...) at the time of upgrade for it to succeed.
• migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

• ❗The break and manual task changelog types will result in a major release!
• 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
• ✨ All others will result in a minor version release.

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Add error-prone rule for converting Stream to Iterator

Check the box to generate changelog(s)

• Generate changelog entry