Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to configure custom database connection #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

patressz
Copy link

@patressz patressz commented Feb 7, 2025

This pull request includes several changes to the DatabaseAnalyticsRepository and PanConfiguration classes to enhance database connection handling. The most important changes include updating the constructor and methods in DatabaseAnalyticsRepository to use the DatabaseManager for database operations, and adding methods to PanConfiguration for setting and getting the database connection.

Enhancements to database connection handling:

  • Updated the constructor to inject DatabaseManager and replaced direct DB facade calls with $this->connection() method to use the configured database connection.
  • Added a private connection() method to resolve the database connection using the configuration.

PanConfiguration:

Added a databaseConnection property and methods to set and get the database connection.

Unit tests:

  • Added a test to verify the databaseConnection can be set and retrieved correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant