Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML autoescape #292

Merged
merged 5 commits into from
Oct 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,18 +56,18 @@ jobs:
os: windows-2022
compiler: msvc

- name: macOS-11-gcc
os: macOS-11
- name: macOS-12-gcc
os: macOS-12
compiler: gcc

- name: macOS-11-clang
os: macOS-11
compiler: clang

- name: macOS-12-clang
os: macOS-12
compiler: clang

# - name: macOS-14-clang
# os: macOS-14
# compiler: clang

steps:
- uses: actions/checkout@v3

Expand Down
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ env.set_expression("{{", "}}"); // Expressions
env.set_comment("{#", "#}"); // Comments
env.set_statement("{%", "%}"); // Statements {% %} for many things, see below
env.set_line_statement("##"); // Line statements ## (just an opener)
env.set_html_autoescape(true); // Perform HTML escaping on all strings
```

### Variables
Expand Down Expand Up @@ -364,6 +365,13 @@ render("{% if neighbour in guests -%} I was there{% endif -%} !", data); //

Stripping behind a statement or expression also removes any newlines.

### HTML escaping

Templates are frequently used to creat HTML pages. Source data that contains
characters that have meaning within HTML (like <. >, &) needs to be escaped.
It is often inconvenient to perform such escaping within the JSON data. With `Environment::set_html_autoescape(true)`, Inja can be configured to
HTML escape each and every string created.

### Comments

Comments can be written with the `{# ... #}` syntax.
Expand Down
1 change: 1 addition & 0 deletions include/inja/config.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ struct ParserConfig {
*/
struct RenderConfig {
bool throw_at_missing_includes {true};
bool html_autoescape {false};
};

} // namespace inja
Expand Down
9 changes: 9 additions & 0 deletions include/inja/environment.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@ class Environment {
render_config.throw_at_missing_includes = will_throw;
}

/// Sets whether we'll automatically perform HTML escape
void set_html_autoescape(bool will_escape) {
render_config.html_autoescape = will_escape;
}

Template parse(std::string_view input) {
Parser parser(parser_config, lexer_config, template_storage, function_storage);
return parser.parse(input, input_path);
Expand Down Expand Up @@ -155,6 +160,10 @@ class Environment {
return os;
}

std::ostream& render_to(std::ostream& os, const std::string_view input, const json& data) {
return render_to(os, parse(input), data);
}

std::string load_file(const std::string& filename) {
Parser parser(parser_config, lexer_config, template_storage, function_storage);
return Parser::load_file(input_path + filename);
Expand Down
22 changes: 21 additions & 1 deletion include/inja/renderer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,29 @@
return !data->empty();
}

static std::string htmlescape(const std::string& data) {
std::string buffer;
buffer.reserve(1.1 * data.size());

Check warning on line 58 in include/inja/renderer.hpp

View workflow job for this annotation

GitHub Actions / test-windows-2019-msvc

'argument': conversion from 'double' to 'const unsigned __int64', possible loss of data [D:\a\inja\inja\build\inja_benchmark.vcxproj]

Check warning on line 58 in include/inja/renderer.hpp

View workflow job for this annotation

GitHub Actions / test-windows-2019-msvc

'argument': conversion from 'double' to 'const unsigned __int64', possible loss of data [D:\a\inja\inja\build\inja_test.vcxproj]

Check warning on line 58 in include/inja/renderer.hpp

View workflow job for this annotation

GitHub Actions / test-windows-2019-msvc

'argument': conversion from 'double' to 'const unsigned __int64', possible loss of data [D:\a\inja\inja\build\inja_test.vcxproj]

Check warning on line 58 in include/inja/renderer.hpp

View workflow job for this annotation

GitHub Actions / test-windows-2019-msvc

'argument': conversion from 'double' to 'const unsigned __int64', possible loss of data [D:\a\inja\inja\build\inja_benchmark.vcxproj]

Check warning on line 58 in include/inja/renderer.hpp

View workflow job for this annotation

GitHub Actions / test-windows-2022-msvc

'argument': conversion from 'double' to 'const unsigned __int64', possible loss of data [D:\a\inja\inja\build\inja_benchmark.vcxproj]

Check warning on line 58 in include/inja/renderer.hpp

View workflow job for this annotation

GitHub Actions / test-windows-2022-msvc

'argument': conversion from 'double' to 'const unsigned __int64', possible loss of data [D:\a\inja\inja\build\inja_test.vcxproj]

Check warning on line 58 in include/inja/renderer.hpp

View workflow job for this annotation

GitHub Actions / test-windows-2022-msvc

'argument': conversion from 'double' to 'const unsigned __int64', possible loss of data [D:\a\inja\inja\build\inja_test.vcxproj]

Check warning on line 58 in include/inja/renderer.hpp

View workflow job for this annotation

GitHub Actions / test-windows-2022-msvc

'argument': conversion from 'double' to 'const unsigned __int64', possible loss of data [D:\a\inja\inja\build\inja_benchmark.vcxproj]
for (size_t pos = 0; pos != data.size(); ++pos) {
switch (data[pos]) {
case '&': buffer.append("&amp;"); break;
case '\"': buffer.append("&quot;"); break;
case '\'': buffer.append("&apos;"); break;
case '<': buffer.append("&lt;"); break;
case '>': buffer.append("&gt;"); break;
default: buffer.append(&data[pos], 1); break;
}
}
return buffer;
}

void print_data(const std::shared_ptr<json> value) {
if (value->is_string()) {
*output_stream << value->get_ref<const json::string_t&>();
if (config.html_autoescape) {
*output_stream << htmlescape(value->get_ref<const json::string_t&>());
} else {
*output_stream << value->get_ref<const json::string_t&>();
}
} else if (value->is_number_unsigned()) {
*output_stream << value->get<const json::number_unsigned_t>();
} else if (value->is_number_integer()) {
Expand Down
34 changes: 32 additions & 2 deletions single_include/inja/inja.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -884,6 +884,7 @@
*/
struct RenderConfig {
bool throw_at_missing_includes {true};
bool html_autoescape {false};
};

} // namespace inja
Expand Down Expand Up @@ -2124,9 +2125,29 @@
return !data->empty();
}

static std::string htmlescape(const std::string& data) {
std::string buffer;
buffer.reserve(1.1 * data.size());

Check warning on line 2130 in single_include/inja/inja.hpp

View workflow job for this annotation

GitHub Actions / test-windows-2019-msvc

'argument': conversion from 'double' to 'const unsigned __int64', possible loss of data [D:\a\inja\inja\build\single_inja_test.vcxproj]

Check warning on line 2130 in single_include/inja/inja.hpp

View workflow job for this annotation

GitHub Actions / test-windows-2019-msvc

'argument': conversion from 'double' to 'const unsigned __int64', possible loss of data [D:\a\inja\inja\build\single_inja_test.vcxproj]

Check warning on line 2130 in single_include/inja/inja.hpp

View workflow job for this annotation

GitHub Actions / test-windows-2022-msvc

'argument': conversion from 'double' to 'const unsigned __int64', possible loss of data [D:\a\inja\inja\build\single_inja_test.vcxproj]

Check warning on line 2130 in single_include/inja/inja.hpp

View workflow job for this annotation

GitHub Actions / test-windows-2022-msvc

'argument': conversion from 'double' to 'const unsigned __int64', possible loss of data [D:\a\inja\inja\build\single_inja_test.vcxproj]
for (size_t pos = 0; pos != data.size(); ++pos) {
switch (data[pos]) {
case '&': buffer.append("&amp;"); break;
case '\"': buffer.append("&quot;"); break;
case '\'': buffer.append("&apos;"); break;
case '<': buffer.append("&lt;"); break;
case '>': buffer.append("&gt;"); break;
default: buffer.append(&data[pos], 1); break;
}
}
return buffer;
}

void print_data(const std::shared_ptr<json> value) {
if (value->is_string()) {
*output_stream << value->get_ref<const json::string_t&>();
if (config.html_autoescape) {
*output_stream << htmlescape(value->get_ref<const json::string_t&>());
} else {
*output_stream << value->get_ref<const json::string_t&>();
}
} else if (value->is_number_unsigned()) {
*output_stream << value->get<const json::number_unsigned_t>();
} else if (value->is_number_integer()) {
Expand Down Expand Up @@ -2382,7 +2403,7 @@
} break;
case Op::Capitalize: {
auto result = get_arguments<1>(node)[0]->get<json::string_t>();
result[0] = std::toupper(result[0]);
result[0] = static_cast<char>(::toupper(result[0]));
std::transform(result.begin() + 1, result.end(), result.begin() + 1, [](char c) { return static_cast<char>(::tolower(c)); });
make_result(std::move(result));
} break;
Expand Down Expand Up @@ -2792,6 +2813,11 @@
render_config.throw_at_missing_includes = will_throw;
}

/// Sets whether we'll automatically perform HTML escape
void set_html_autoescape(bool will_escape) {
render_config.html_autoescape = will_escape;
}

Template parse(std::string_view input) {
Parser parser(parser_config, lexer_config, template_storage, function_storage);
return parser.parse(input, input_path);
Expand Down Expand Up @@ -2854,6 +2880,10 @@
return os;
}

std::ostream& render_to(std::ostream& os, const std::string_view input, const json& data) {
return render_to(os, parse(input), data);
}

std::string load_file(const std::string& filename) {
Parser parser(parser_config, lexer_config, template_storage, function_storage);
return Parser::load_file(input_path + filename);
Expand Down
Loading