Remove mustdown gem #119
Merged
Remove mustdown gem #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After investigation it turns out rubyparis.org is down every now and then because the mustdown gem isn't threadsafe and puma is configured to use threads (see cowboyd/handlebars.rb#46 and cowboyd/handlebars.rb#39)
here is a video showing puma getting stuck:
https://youtu.be/7zVW53SQtiE
And with the fix:
https://youtu.be/JPYmTgJj7eA
Do not focus on the 500 errors this is because #117 and #118 need to be merged first.
The important thing to observe is that on the first video puma hangs and is down and on the second it is working with no downtime