Add search by validator key to whois #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstakhov
approved these changes
Apr 28, 2023
whois/src/main.rs
Outdated
| let node_network_id = node.details.network_id.clone(); | ||
| if node_network_id == Some(network_id) { | ||
| *holder = Some(node.node_id); | ||
| fn save_node_id(node: &AddedNode, authority_key: AccountId32, holder: &mut Option<FeedNodeId>) { |
There was a problem hiding this comment.
Cannot we just return an Option<FeedNodeId>, as the current approach reminds me the plain C one.
sandreim
reviewed
May 1, 2023
There was a problem hiding this comment.
Looks good. I have 2 questions:
- how does this relate to Telemetry support #283
- does it still require interaction to select chain before it outputs information ?
Yeah, the telemetry collects data from different chains. Polkadot telemetry, for example, has data from polkadot and kusama with their parachains. So we need to specify our chain. Another option could be to go throw all the chains, subscribing and receiving a few first messages, then resubscribing to another chain. But I can't sat I like it. |
It should partially close the requirements of validator key tracking |
sandreim
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.