Update pallet conviction voting to support Block Number Provider

[dharjeezy]

This PR introduces BlockNumberProvider config for the conviction voting pallet.
closes part of #6297

Polkadot address: 12GyGD3QhT4i2JJpNzvMf96sxxBLWymz4RdGCxRH5Rj5agKW

[dharjeezy]

can you help review this too @gui1117

[gui1117]

Looks good to me

[PolkadotDom]

Does this need a migration? If I'm reading correctly looks like the locks would expire prematurely for Parachains if BlockNumberProvider was set to relaychain. Though perhaps premature lock expiration isn't worth the hassle / might just be Hydration w/ the conviction pallet.

[gui1117]

Does this need a migration? If I'm reading correctly looks like the locks would expire prematurely for Parachains if BlockNumberProvider was set to relaychain. Though perhaps premature lock expiration isn't worth the hassle / might just be Hydration w/ the conviction pallet.

you are right.
Some pallet are on polkadot relay chain and we introduce the block number provider so that we can move them to asset hub and at the same time keeping the block number as provided by the relay chain. In this scenario we might not need a migration because we move from relay chain to asset hub with block number provided by relay chain.

That said a migration is always good to have for all other situations.

[muharem]

bot help

[command-bot]

Here's a link to docs

[github-actions]

We have migrated the command bot to GHA

Please, see the new usage instructions here or here. Soon the old commands will be disabled.

[muharem]

bot fmt

[command-bot]

@muharem https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8160694 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-365b9fc9-76e8-416a-999b-74f01eb16c80 to cancel this command or bot cancel to cancel all commands in this pull request.

[github-actions]

We have migrated the command bot to GHA

Please, see the new usage instructions here or here. Soon the old commands will be disabled.

[command-bot]

@muharem Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8160694 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8160694/artifacts/download.

[gui1117]

maybe all 3 PRs: #6715 #6623 and #6621 could altogether get a small tip.
But I don't have writes for tipping