Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimistic Project Funding #6994

Open
wants to merge 123 commits into
base: master
Choose a base branch
from
Open

Optimistic Project Funding #6994

wants to merge 123 commits into from

Conversation

ndkazu
Copy link
Contributor

@ndkazu ndkazu commented Dec 24, 2024

Description

This PR is related to this issue .
Through the introduction of the OPF pallet and the DISTRIBUTION pallet, we are handling the Optimistic Project Funding.
It allows users to nominate projects (whitelisted in OpenGov) with their DOT. This mechanism will be funded with a constant stream of DOT taken directly from inflation and distributed to projects based on the proportion of DOT that has nominated them.

Integration

Review Notes

Terminology

The constants available in the runtime for the OPF Pallet:

  • MaxProjects: Maximum number of Whitelisted projects that can be handled by the pallet.
  • VotingPeriod: Period in which people can vote. After the period has ended, the votes are counted (STOP THE COUNT) and then the funds are distributed into Spends.
  • ClaimingPeriod: Time for claiming a Spend. After the period has passed, a spend is thrown away and the funds are available again for distribution in the pot.
  • VoteValidityPeriod: Period after which all the votes are reset.

Functions

  • - register_project: Register by OpenGov, should take AccountId and project Purpose.
  • - unregister_project: Unregister by OpenGov
  • - claim: To claim a spend

Checklist

pallet-opf

  • Pallet Config
  • Helper functions
  • Extrinsics
  • Events & Tests
  • Benchmarking & weights
  • Remove Dev-mode
  • Proper documentation

@ndkazu ndkazu requested a review from a team as a code owner December 24, 2024 12:34
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can open the PR as a draft until it is ready.

Or ping when it is ready.

substrate/frame/opf/src/types.rs Outdated Show resolved Hide resolved
substrate/frame/opf/src/lib.rs Show resolved Hide resolved
substrate/frame/opf/src/function.rs Outdated Show resolved Hide resolved
substrate/frame/opf/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/opf/src/lib.rs Outdated Show resolved Hide resolved
@gui1117 gui1117 marked this pull request as draft December 29, 2024 10:13
substrate/frame/opf/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/opf/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/opf/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/opf/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/opf/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/opf/src/functions.rs Show resolved Hide resolved
substrate/frame/opf/src/types.rs Outdated Show resolved Hide resolved
substrate/frame/opf/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/opf/src/types.rs Outdated Show resolved Hide resolved
substrate/frame/opf/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@pandres95 pandres95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some pretty superficial notes to start my review. Can continue with a more detailed review later tomorrow.

As a general remark, if you have a voting schema that somehow resembles what's already out there on OpenGov, I suggest you consider exploring the pallets that implement Tally and integrate with pallet-referenda.

substrate/frame/opf/Cargo.toml Outdated Show resolved Hide resolved
substrate/frame/opf/Cargo.toml Outdated Show resolved Hide resolved
substrate/frame/opf/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/opf/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/opf/src/lib.rs Show resolved Hide resolved
substrate/frame/opf/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/opf/src/lib.rs Outdated Show resolved Hide resolved
@ndkazu
Copy link
Contributor Author

ndkazu commented Feb 6, 2025

Some pretty superficial notes to start my review. Can continue with a more detailed review later tomorrow.

As a general remark, if you have a voting schema that somehow resembles what's already out there on OpenGov, I suggest you consider exploring the pallets that implement Tally and integrate with pallet-referenda.

@pandres95 and @kianenigma , I have a question: Is there a reason for Not using pallet-democracy?
During the PBA, I was told that open-gov not being one pallet, implementation is a "bit" complex (Is there a resource I can check that is describing how it's done?).
Looking into pallet-referenda & pallet-conviction, It felt like way more work to implement something using both of these pallets together, than simply using pallet-democracy. But I will gladly dive into it, if it is ABSOLUTELY necessary, I just want to understand the "why"...

@ndkazu ndkazu requested a review from pandres95 February 9, 2025 14:40
@franciscoaguirre franciscoaguirre added the T2-pallets This PR/Issue is related to a particular pallet. label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants