Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2412] Backport #7307 #7347

Open
wants to merge 2 commits into
base: stable2412
Choose a base branch
from

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #7307 into stable2412 from bkontur.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk
Copy link
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7307-to-stable2412
git worktree add --checkout .worktree/backport-7307-to-stable2412 backport-7307-to-stable2412
cd .worktree/backport-7307-to-stable2412
git reset --hard HEAD^
git cherry-pick -x 085da479dee8e09ad3de83dbc59b304bd36b4ebe
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Jan 27, 2025
Copy link
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

This PR contains small fixes identified during work on the larger PR:
#6906.

---------

Co-authored-by: command-bot <>
(cherry picked from commit 085da47)
@bkontur bkontur force-pushed the backport-7307-to-stable2412 branch from e9ec0b8 to 6341158 Compare January 29, 2025 12:36
@bkontur bkontur marked this pull request as ready for review January 29, 2025 12:45
@bkontur bkontur requested a review from a team as a code owner January 29, 2025 12:45
@bkontur bkontur enabled auto-merge (squash) January 29, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants