Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorter availability data retention period for testnets #7353

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

s0me0ne-unkn0wn
Copy link
Contributor

Closes #3270

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12996813840
Failed job name: fmt

@s0me0ne-unkn0wn
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Jan 27, 2025

@s0me0ne-unkn0wn https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8101868 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-0681a7d1-ae71-4acc-b45d-dfa43f9196cf to cancel this command or bot cancel to cancel all commands in this pull request.

Copy link
Contributor

We have migrated the command bot to GHA

Please, see the new usage instructions here or here. Soon the old commands will be disabled.

@command-bot
Copy link

command-bot bot commented Jan 27, 2025

@s0me0ne-unkn0wn Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8101868 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8101868/artifacts/download.

@s0me0ne-unkn0wn s0me0ne-unkn0wn marked this pull request as ready for review January 28, 2025 14:43
@s0me0ne-unkn0wn
Copy link
Contributor Author

Okay, let's start with this. Consider this a draft, as I'm not quite sure in some points.

polkadot/node/service/src/lib.rs Outdated Show resolved Hide resolved
polkadot/node/service/src/lib.rs Outdated Show resolved Hide resolved
let availability_config = AvailabilityConfig {
col_data: parachains_db::REAL_COLUMNS.col_availability_data,
col_meta: parachains_db::REAL_COLUMNS.col_availability_meta,
keep_finalized_for: if matches!(config.chain_spec.chain_type(), ChainType::Live) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure this will have the desired effect ?

.with_chain_type(ChainType::Live)

What is the chain_type() for

WestendChainSpec::from_json_bytes(&include_bytes!("../chain-specs/westend.json")[..])
?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it. Now the question is, do we want 1 hour default period for all the non-production networks (that is, including Westend and stuff)? Or do we want to have 25 by default and only make it possible to lower it explicitly with the cli flag?

@s0me0ne-unkn0wn s0me0ne-unkn0wn added the T0-node This PR/Issue is related to the topic “node”. label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shorter availability data retention period for testnets
3 participants