-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorter availability data retention period for testnets #7353
base: master
Are you sure you want to change the base?
Conversation
All GitHub workflows were cancelled due to failure one of the required jobs. |
bot fmt |
@s0me0ne-unkn0wn https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8101868 was started for your command Comment |
@s0me0ne-unkn0wn Command |
Okay, let's start with this. Consider this a draft, as I'm not quite sure in some points. |
polkadot/node/service/src/lib.rs
Outdated
let availability_config = AvailabilityConfig { | ||
col_data: parachains_db::REAL_COLUMNS.col_availability_data, | ||
col_meta: parachains_db::REAL_COLUMNS.col_availability_meta, | ||
keep_finalized_for: if matches!(config.chain_spec.chain_type(), ChainType::Live) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure this will have the desired effect ?
.with_chain_type(ChainType::Live) |
What is the chain_type()
for
WestendChainSpec::from_json_bytes(&include_bytes!("../chain-specs/westend.json")[..]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it. Now the question is, do we want 1 hour default period for all the non-production networks (that is, including Westend and stuff)? Or do we want to have 25 by default and only make it possible to lower it explicitly with the cli flag?
Closes #3270