network/tests: Add conformance testing for litep2p and libp2p #7361
Conversation
connectivity Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
lexnv
added
R0-silent
| NotificationEvent::NotificationReceived { .. } => { | ||
| received += 1; | ||
| if received >= ping_pong_num { | ||
| break; | ||
| } | ||
|
|
||
| notifications_left.send_async_notification(&right_peer_id, vec![1, 2, 3]).await.unwrap(); | ||
| } |
There was a problem hiding this comment.
dq: Why is this part of connect_notifications and not of a higher level test?
There was a problem hiding this comment.
That's a good point, I'll revert this and await 1 notification before handing this to the tests 🙏
There was a problem hiding this comment.
Why do we need to await any notifications here at all?
There was a problem hiding this comment.
Wanted to not repeat the awaiting on listen addresses, add_reserved_peer and accepting substreams via: NotificationEvent::NotificationStreamOpened and NotificationEvent::ValidateInboundSubstream in other tests
There was a problem hiding this comment.
Yeah, understand — I mean why we need to send notification / handle NotificationEvent::NotificationReceived in the setup code?
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
This PR implements conformance tests between our network backends (litep2p and libp2p).
The PR creates a setup for extending testing in the future, while implementing the following tests:
cc @paritytech/networking