Add chain properties to chain-spec-builder #7368
Open
+125
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
reviewed
Jan 28, 2025
| /// Chain properties in comma-separated KEY=VALUE format. | ||
| /// Example: `--properties tokenSymbol=UNIT,tokenDecimals=12,ss58Format=42,isEthereum=false` | ||
| #[arg(long)] | ||
| pub properties: Option<String>, |
There was a problem hiding this comment.
Suggested change
| pub properties: Option<String>, | |
| pub properties: Vec<String>, |
There was a problem hiding this comment.
Changed in 1b8e84a.
Comment on lines
86
to
87
| /// Chain properties in comma-separated KEY=VALUE format. | ||
| /// Example: `--properties tokenSymbol=UNIT,tokenDecimals=12,ss58Format=42,isEthereum=false` |
There was a problem hiding this comment.
Suggested change
| /// Chain properties in comma-separated KEY=VALUE format. | |
| /// Example: `--properties tokenSymbol=UNIT,tokenDecimals=12,ss58Format=42,isEthereum=false` | |
| /// Chain properties in `KEY=VALUE` format. | |
| /// | |
| /// Multiple `KEY=VALUE` entries can be specified and separated by a comma. | |
| /// | |
| /// Example: `--properties tokenSymbol=UNIT,tokenDecimals=12,ss58Format=42,isEthereum=false` | |
| /// Or: `--properties tokenSymbol=UNIT --properties tokenDecimals=12 --properties ss58Format=42 --properties=isEthereum=false` | |
| /// | |
| /// The first uses comma as separation and the second passes the argument multiple times. Both | |
| /// styles can also be mixed. |
Comment on lines
397
to
398
| let key = iter.next().unwrap_or("").trim().to_owned(); | ||
| let value_str = iter.next().unwrap_or("").trim(); |
There was a problem hiding this comment.
If they don't exist, it should be an error.
bkchr
approved these changes
Jan 29, 2025
| fn parse_properties(raw: &String, props: &mut sc_chain_spec::Properties) -> Result<(), String> { | ||
| for pair in raw.split(',') { | ||
| let mut iter = pair.splitn(2, '='); | ||
| let key = iter.next().ok_or("Invalid chain property key")?.trim().to_owned(); |
There was a problem hiding this comment.
Suggested change
| let key = iter.next().ok_or("Invalid chain property key")?.trim().to_owned(); | |
| let key = iter.next().ok_or_else(|| format!("Invalid chain property key: {pair}"))?.trim().to_owned(); |
There was a problem hiding this comment.
Addressed in d9b1292.
auto-merge was automatically disabled
January 29, 2025 21:39
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for chain properties to
chain-spec-builder. Now properties can be specified as such:$ chain-spec-builder create -r $RUNTIME_PATH --properties tokenSymbol=DUMMY,tokenDecimals=6,isEthereum=false