fix(sync-templates): keep parachain-template's workspace Cargo.toml #7439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
iulianbarbu
requested review from
seemantaggarwal and
skunert
and removed request for
a team
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
iulianbarbu
added
the
R0-silent
skunert
approved these changes
Feb 3, 2025
seemantaggarwal
approved these changes
Feb 4, 2025
Merged
via the queue into
paritytech:master
with commit Feb 4, 2025
0e386be
243 of 337 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another small fix for sync-templates. We're copying the
polkadot-sdk'sparachain-templatefiles (including theparachain-template-docs's Cargo.toml) to the directory where we're creating the workspace with allparachain-templatemembers crates, and workspace's toml. The error is that in this directory for the workspace we first create the workspace's Cargo.toml, and then copy the files of thepolkadot-sdk'sparachain-template, including theCargo.tomlof theparachain-template-docscrate, which overwrites the workspace Cargo.toml. In the end we delete theCargo.toml(which we assume it is of theparachain-template-docscrate), forgetting that previously there should've been a workspace Cargo.toml, which should still be kept and committed to the template's repository.The error happens here: https://github.com/paritytech/polkadot-sdk/actions/runs/13111697690/job/36577834127
Integration
N/A
Review Notes
Once again, merging this into master requires re-running sync templates based on latest version on master. Hopefully this will be the last issue related to the workflow itself.