Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libp2p: Enhance logging targets for granular control #7494

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

libp2p: Enhance logging targets for granular control #7494

wants to merge 9 commits into from
+239 −206

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Feb 6, 2025

This PR modifies the libp2p networking-specific log targets for granular control (e.g., just enabling trace for req-resp).

Previously, all logs were outputted to sub-libp2p target, flooding the log messages on busy validators.

Changes

  • Discover: sub-libp2p::discovery
  • Notification/behaviour: sub-libp2p::notification::behaviour
  • Notification/handler: sub-libp2p::notification::handler
  • Notification/service: sub-libp2p::notification::service
  • Notification/upgrade: sub-libp2p::notification::upgrade
  • Request response: sub-libp2p::request-response

cc @paritytech/networking

lexnv added 7 commits February 6, 2025 11:16
@lexnv
libp2p/notifications: Fix log target
a766be7 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
libp2p/notif: Fix log for behaviour
83d3939 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
libp2p/notif: Fix target for upgrade
5d73594 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
libp2p/notif: Fix target for service
1621742 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
libp2p/discovery: Fix log target
e9c9293 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
libp2p/req-resp: Fix log target
21f7214 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
libp2p/service: Fix log target to constant
5bd2c96 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv added the T0-node This PR/Issue is related to the topic “node”. label Feb 6, 2025
@lexnv lexnv self-assigned this Feb 6, 2025
lexnv and others added 2 commits February 6, 2025 11:36
@lexnv
Add PR doc
393ede3 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv
Merge branch 'master' into lexnv/fine-control-logs-libp2p
71027cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lexnv lexnv

Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lexnv