This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Bump schnorrkel to 0.8.3 #3283
Merged
Bump schnorrkel to 0.8.3 #3283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Aug 1, 2019
| Ok(some_signature) => some_signature, | ||
| Err(_) => return false | ||
| }; | ||
| // Match both schnorrkel 0.1.1 and 0.8.0+ signatures, supporting both wallets |
There was a problem hiding this comment.
I think we should open an issue for this? So we don't forget to switch.
There was a problem hiding this comment.
Probably. And/or on schnorrkel. I'll remove the preaudit_deprecated feature entirely whenever all testnets migrate.
There was a problem hiding this comment.
Okay, yeah then let's add this issue to schnorrkel.
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
folsen
pushed a commit
that referenced
this pull request
Aug 7, 2019
* Update to schnorrkel `0.8.0` * Increase `spec_version` * Bump schnorrkel to 0.8.3 (#3283) * Schnorrkel 0.8.1 (builds on bkchr upgrade branch) * Add tests for known hard/soft derivation values * Bump all schnorrkel versions * Flatten for easier inspection * 0.8.2 * 0.8.3 * Update subkey/Cargo.toml Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com> * Update `Cargo.lock` * 0.8.4 * Fix cargo lock file. * Adding an error message for `NotMarkedSchnorrkel` as that was missing. Also fixing a typo, strage -> stage.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bkchr This is intended to merge into your upgrade branch.