Take into account exif rotation information when scaling images. #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this app! I've started using it recently and it's been a great experience so far.
The only issue I've run into so far is that when I try to upload photos from my camera, they are always rotated by 90 degrees. Looking at #877, this seems to happen for other users as well.
I looked into the code and it seems to happen during image scaling, because some photos are stored rotated with orientation information in the exif metadata. Here's an attempt to take that rotation information into account and optionally rotate during scaling.
Smoke tested on a Pixel 7.