MDL-84072 output: correct progress bar component percentage parameter.

Avoid mixing float/string types, where the decimal separator could
vary according to current locale (as per previous fix 5a1aef5, which
was subsequently re-broken by b92886a).

lib/classes/output/core_renderer.php

@@ -4765,7 +4765,13 @@ public function render_progress_bar(progress_bar $bar) {
      */
     public function render_progress_bar_update(string $id, float $percent, string $msg, string $estimate,
         bool $error = false): string {
-        return html_writer::script(js_writer::function_call('updateProgressBar', [$id, $percent, $msg, $estimate, $error]));
+        return html_writer::script(js_writer::function_call('updateProgressBar', [
+            $id,
+            round($percent, 1),
+            $msg,
+            $estimate,
+            $error,
+        ]));
     }
 
     /**

lib/classes/output/progress_bar.php

@@ -181,7 +181,7 @@ protected function update_raw($percent, $msg) {
         $this->lastupdate = microtime(true);
 
         if ($this->autoupdate) {
-            echo $OUTPUT->render_progress_bar_update($this->idnumber, sprintf("%.1f", $this->percent), $msg, $estimatemsg);
+            echo $OUTPUT->render_progress_bar_update($this->idnumber, $this->percent, $msg, $estimatemsg);
             flush();
         }
     }
@@ -307,7 +307,7 @@ public function error(string $errormsg): void {
         $this->message = $errormsg;
 
         if ($this->autoupdate) {
-            echo $OUTPUT->render_progress_bar_update($this->idnumber, sprintf("%.1f", $this->percent), $errormsg, '', true);
+            echo $OUTPUT->render_progress_bar_update($this->idnumber, $this->percent, $errormsg, '', true);
             flush();
         }
     }

lib/classes/output/stored_progress_bar.php

@@ -299,7 +299,7 @@ protected function render_update(): void {
         // If we want the screen to auto update, render it.
         if ($this->autoupdate) {
             echo $OUTPUT->render_progress_bar_update(
-                $this->idnumber, sprintf("%.1f", $this->percent), $this->message, $this->get_estimate_message($this->percent)
+                $this->idnumber, $this->percent, $this->message, $this->get_estimate_message($this->percent)
             );
         }
     }