MDL-83537 check: confirm presence of instance action link.

paulholden · Feb 3, 2025 · ba4c294 · ba4c294
1 parent 89e6f73
commit ba4c294
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/adminlib.php b/lib/adminlib.php
@@ -11800,7 +11800,9 @@ public function output_html($data, $query = '') {
         $output = $OUTPUT->notification($loadingicon . $loadingstr, \core\output\notification::NOTIFY_INFO, false);
 
         // Add the action link.
-        $output .= $OUTPUT->render($this->check->get_action_link());
+        if ($actionlink = $this->check->get_action_link()) {
+            $output .= $OUTPUT->render($actionlink);
+        }
 
         // Wrap in a div with a reference. The JS getAndRender will replace this with the response from the webservice.
         $statusdiv = \html_writer::div($output, '', ['data-check-reference' => $domref]);

diff --git a/lib/classes/output/core_renderer.php b/lib/classes/output/core_renderer.php
@@ -1351,7 +1351,9 @@ protected function render_check_full_result(check_check $check, check_result $re
         }
 
         // Add the action link.
-        $renderedresult .= $this->render_action_link($check->get_action_link());
+        if ($actionlink = $check->get_action_link()) {
+            $renderedresult .= $this->render_action_link($actionlink);
+        }
 
         return $renderedresult;
     }