Cargo.toml: Only enable mysql_backend on diesel, not the whole mysql feature #707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the
mysql_backend
feature is required for the traits/types;mysql
pulls in the full MySQL client machinery (includingmysqlclient-sys
, which pulls in openssl, etc)This only benefits
diesel_async
users, as far as I can tell;diesel_async
uses separate connection machinery (mysql_async
,mysql_common
), which is pure Rust and uses a more permissive licenseI would guess that the same could be applied to
db-diesel-postgres
, asdiesel
does have apostgers_backend
feature which looks like it's a similar subset of thepostgres
feature, but I couldn't test that as we're only a MySQL shop and didn't want to submit anything untested.Note that this may be considered a breaking change. Downstream crates/applications that pull in
rust_decimal
'sdb-diesel-mysql
feature but notdiesel
'smysql
feature, and which need to actually connect to MySQL usingdiesel
's sync connections, are currently relying on the transitive dependency and will experience build failures.