Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align media right and add alt tags #50

Open
wants to merge 12 commits into
base: gh-pages
Choose a base branch
from
Open

Conversation

micey969
Copy link
Contributor

@micey969 micey969 commented Jul 3, 2018

Reference 32 and 34

Please note, concerning the media--right code, it was only added to the stylesheet, I didn't add any code for it inside of the pages, I only added the alt tags to those pages.

Problem:

  • On screen sizes >=960px, when wrapped in a section div, figure.media should be displayed top right of section instead of full width
  • Images on the site had no alt tags so screen readers wouldn't be able to tell users what the images were about
    Solution:
  • Make div.section into a flexbox so its contents can be easily be displayed inline on screens >=960px and full width on screens <960px
  • add alt tags for visitors that use screen readers
    Results:
  • Figure.media images are aligned top right in screens >=960px and are full width in screens <960px once they bear the label figure.media--stretched.media--right

Attachments
screens >=960px
image

screens <960px
image

@micey969 micey969 requested a review from johnsBeharry July 3, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants