-
Notifications
You must be signed in to change notification settings - Fork 27
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(deps): Remove check-types in favor of lodash
Since the creation of this module we have largely settled on lodash as our Javascript helper library of choice. This module was now using both, which seemed excessive and inconsistent. This change replaces all use of `check-types` with equivalent lodash functionality. One notable conceptual change is regarding what is valid to store in a `Variable` object used as placeholder values in queries. Initially, only scalar values were supported: non-empty strings, numbers, and booleans. However, over time we found it useful to store first arrays and then even objects as variables, meaning its now clearer to enumerate what a `Variable` _doesn't_ support storing: empty strings, `null`, and `undefined`
- Loading branch information
1 parent
32089ce
commit 0910125
Showing
3 changed files
with
14 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters