8.0 Fix PXB-3210: PXB fails to build on macOS since 8.0.33-28 due to FIND_PRO… #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CPS() https://jira.percona.com/browse/PXB-3210 When predicting required memory for prepare (PXB-2710) `sys/sysctl` is used by macOS and `proc/sysinfo` by other systems for memory calculation. As part of the PXB-2993 fix to make the memory calculation logic compatible with procps-4 procps.cmake file was introduced to detect the version during cmake, but cmake macro is not accounting for macOS and and failing to find procps on macOS. Now we make sure that cmake does not search for procps on macOS.
aybek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…CPS()
https://jira.percona.com/browse/PXB-3210
When predicting required memory for prepare (PXB-2710)
sys/sysctlis used by macOS andproc/sysinfoby other systems for memory calculation. As part of the PXB-2993 fix to make the memory calculation logic compatible with procps-4 procps.cmake file was introduced to detect the version during cmake, but cmake macro is not accounting for macOS and and failing to find procps on macOS. Now we make sure that cmake does not search for procps on macOS.