Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PXB-3220 tolerate file deletion between discovery and file open #1539

Closed
wants to merge 1 commit into from
Closed

PXB-3220 tolerate file deletion between discovery and file open #1539

wants to merge 1 commit into from

Conversation

aybek
Copy link
Contributor

@aybek aybek commented Jan 22, 2024 •
edited
Loading

This PR contains fixes to

  • PXB-3220 tolerate file deletion between discovery and file open
  • PXB-3227 Dropped table is still in the backup
  • PXB-3229 Can't create/write to file 't2.ibd.del' (OS errno 17 - File exists)
  • PXB-3231 When handling renames: t1.ibd.ren file already exists

@aybek aybek force-pushed the dev-reducedlock-trunk branch 3 times, most recently from 7183995 to 268ae9a Compare January 22, 2024 09:17
satya-bodapati
satya-bodapati reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@satya-bodapati satya-bodapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Aibek. Lets add some testcases with debug_sync.
with the debug sync point

  1. drop a table between discovery and open
  2. rename a table between discovery and open
  3. ALTER TABLE (this isn't an issue, but to be safe)

@aybek aybek force-pushed the dev-reducedlock-trunk branch 3 times, most recently from 72972b4 to a812035 Compare January 24, 2024 10:26
satya-bodapati
satya-bodapati requested changes Jan 24, 2024
View reviewed changes
storage/innobase/xtrabackup/src/ddl_tracker.h Outdated Show resolved Hide resolved
storage/innobase/xtrabackup/src/ddl_tracker.h Outdated Show resolved Hide resolved
storage/innobase/xtrabackup/src/ddl_tracker.cc Outdated Show resolved Hide resolved
storage/innobase/fil/fil0fil.cc Outdated Show resolved Hide resolved
@aybek aybek force-pushed the dev-reducedlock-trunk branch 5 times, most recently from ba09c83 to 794caa8 Compare January 29, 2024 18:08
@aybek aybek requested a review from satya-bodapati January 30, 2024 04:53
@aybek aybek force-pushed the dev-reducedlock-trunk branch 10 times, most recently from d964bfb to e03db06 Compare February 1, 2024 08:34
@aybek
PXB-3248 Multiple files found for the same tablespace ID
c924735 
On prepare phase when handling ddl files some of the data files were not loaded to cache because of the first page validation
therefore were left without applying ddls on them.
To tolerate this issue we should open and load data files to cache without validation,to do so we are
using fil_tablespace_open_for_recovery() function instead of fil_open_for_xtrabackup().
@aybek aybek force-pushed the dev-reducedlock-trunk branch from e03db06 to c924735 Compare May 15, 2024 05:42
@aybek aybek closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satya-bodapati satya-bodapati Awaiting requested review from satya-bodapati

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aybek @satya-bodapati