PMM-10180: disable http compression by default #954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,7 +43,7 @@ require ( | |||
| github.com/percona/exporter_shared v0.7.3 | |||
| github.com/percona/go-mysql v0.0.0-20210427141028-73d29c6da78c | |||
| github.com/percona/percona-toolkit v3.2.1+incompatible | |||
| github.com/percona/promconfig v0.2.4-0.20211110115058-98687f586f54 | |||
There was a problem hiding this comment.
Damn! @BupycHuk It seem that we were targeting this percona/promconfig#12 😖
We forgot to merge promconfig or we added this dependency here accidentally?
Comment on lines
+199
to
+201
| for _, scfg := range scfgs { | ||
| scfg.DisableCompression = true | ||
| } |
There was a problem hiding this comment.
But how can I enable it then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved from percona/pmm-managed#1157
PMM-10180
Build:
Percona-Lab/pmm-submodules#2569
Related PR:
percona/promconfig#14