Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for JSON comments #34

Open
apertome opened this issue Aug 30, 2018 · 1 comment · May be fixed by #164
Open

Add support for JSON comments #34

apertome opened this issue Aug 30, 2018 · 1 comment · May be fixed by #164
Assignees
@arlake228 @valtersg
Labels
enhancement New feature or request

Comments

@apertome
Copy link

Users requested the ability to add JSON comments to the psconfig json files. Hopefully this could be implemented in a way that's consistent with how pscheduler handles this.
@mfeit-internet2
Copy link
Member

FYI, the rules for that in pScheduler is that any member of an object whose identity (left side) begins with # is deleted from the object during parsing.

The code that does it is here: https://github.com/perfsonar/pscheduler/blob/47078cbaac5212330eeeaa9c51f3eac23a0ee883/python-pscheduler/pscheduler/pscheduler/psjson.py#L13

It's also the same function that nulls out pairs that have to be kept secret.

@arlake228 arlake228 self-assigned this Sep 5, 2018
@github-project-automation github-project-automation bot moved this to Ready in perfSONAR May 9, 2023
@laeti-tia laeti-tia added the enhancement New feature or request label Feb 25, 2025
@valtersg valtersg linked a pull request Mar 3, 2025 that will close this issue
Open
@valtersg valtersg linked a pull request Mar 3, 2025 that will close this issue
Fixes-issue-34 #164
Open
@valtersg valtersg moved this from Ready to In Review in perfSONAR Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arlake228 arlake228

@valtersg valtersg

Labels
enhancement New feature or request
Projects
perfSONAR
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes-issue-34 perfsonar/psconfig
5 participants
@laeti-tia @arlake228 @valtersg @apertome @mfeit-internet2