Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes-issue-34 #164

Open
wants to merge 3 commits into
base: 5.2.0
Choose a base branch
from
Open

Fixes-issue-34 #164

wants to merge 3 commits into from

Conversation

valtersg
Copy link

@valtersg valtersg commented Mar 3, 2025

pScheduler style 'comments' in JSON files.
JSON "keys" that start with # will be considered "comments" and ignored when parsing the config file.

example /etc/perfsonar/psconfig/pscheduler-agent.json:

{
	'remotes': [],
	'#comment': "example"
}

previously gave an error:

...Error: Additional properties are not allowed ('#comment' were unexpected)

now - no errors.

code from pScheduler

@valtersg valtersg linked an issue Mar 3, 2025 that may be closed by this pull request
@valtersg valtersg requested a review from laeti-tia March 3, 2025 13:58
@laeti-tia
Copy link
Member

Looking good to me. But maybe we could also include python3-pscheduler as a dependency so as not to duplicate the code. @arlake228 shall we push this to 5.3.0 so to better review this?

@laeti-tia laeti-tia requested a review from arlake228 March 11, 2025 18:09
@valtersg
Copy link
Author

@laeti-tia
rewrote the comment functionality as a dependency from python3-pscheduler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for JSON comments
2 participants