Adding support to set port externally with system property #478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately Spark doesn't support setting port from system property. It's sometimes nessesery to give port for example in Heroku https://devcenter.heroku.com/articles/java-faq#what-constraints-should-i-be-aware-of-when-developing-applications-on-heroku:
In Spring Boot you can give port from command line like this:
java -Dserver.port=$PORT -jar spring-app-1.0.0.jar
In WildFly Swarm you also can give port like this:
java -Dswarm.http.port=$PORT -jar swarm-app-1.0.0.jar
I'm proposing to solve this by using the same property name as in Spring Boot
server.port
for easier migration between those two.This PR will also makes posible my feature for Gasper: wavesoftware/java-gasper#1
I tested those changes with test application.