Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add review address #56

Closed
wants to merge 1 commit into from
Closed

Conversation

dayeon5470
Copy link

No description provided.

@msk
Copy link
Contributor

msk commented Feb 13, 2024

Thank you for your pull request and for contributing to this project. I noticed that your PR proposes adding the review_address field to the Configuration struct in src/request.rs. Before we proceed, could you please provide some rationale behind this change?

Understanding the context and reasoning for this modification will help us assess its impact on the protocol between REview and its clients. Specifically, we're interested in:

  • The problem or limitation you encountered that led to proposing this change.
  • How the addition of review_address improves or affects the functionality or performance of the protocol.
  • Any potential implications or adjustments that might be required for existing clients using this field.

Your insights on these points would be greatly appreciated and would greatly aid in our review process.

@sophie-cluml
Copy link
Contributor

@dayeon5470 Let's discuss the change of Configuration in #58. Please close this issue (I cannot close this issue)

@dayeon5470 dayeon5470 closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants