Increase default values for hint max column/row count to accommodate …

…for vertical screens
petoncle · Dec 17, 2024 · 1788f3f · 1788f3f
1 parent c61cc23
commit 1788f3f
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 10 deletions.
diff --git a/configuration/author.properties b/configuration/author.properties
@@ -269,8 +269,6 @@ hint1-mode.hide-cursor.idle-duration-millis=0
 hint1-mode.hint.type=grid
 hint1-mode.hint.grid-area=active-screen
 hint1-mode.hint.active-screen-grid-area-center=screen-center
-hint1-mode.hint.grid-max-row-count=17
-hint1-mode.hint.grid-max-column-count=22
 #hint1-mode.hint.grid-cell-width=60
 hint1-mode.hint.grid-cell-width=87
 hint1-mode.hint.grid-cell-height=63

diff --git a/configuration/mouseable.properties b/configuration/mouseable.properties
@@ -152,8 +152,6 @@ hint1-mode.to.previous-mode-from-history-stack=+leftalt -leftalt | +esc | +backs
 hint1-mode.hint.type=grid
 hint1-mode.hint.grid-area=active-screen
 hint1-mode.hint.active-screen-grid-area-center=screen-center
-hint1-mode.hint.grid-max-row-count=26
-hint1-mode.hint.grid-max-column-count=26
 hint1-mode.hint.grid-cell-width=73
 hint1-mode.hint.grid-cell-height=41
 key-alias.hint1key=a b c d e f g h i j k l m n o p q r s t u v w x y z

diff --git a/configuration/neo-mousekeys.properties b/configuration/neo-mousekeys.properties
@@ -218,8 +218,6 @@ hint1-mode.hide-cursor.idle-duration-millis=0
 hint1-mode.hint.type=grid
 hint1-mode.hint.grid-area=active-screen
 hint1-mode.hint.active-screen-grid-area-center=screen-center
-hint1-mode.hint.grid-max-row-count=26
-hint1-mode.hint.grid-max-column-count=26
 hint1-mode.hint.grid-cell-width=73
 hint1-mode.hint.grid-cell-height=41
 hint1-mode.hint.undo=backspace

diff --git a/configuration/warpd.properties b/configuration/warpd.properties
@@ -147,8 +147,6 @@ hint1-mode.to.previous-mode-from-history-stack=+esc | +backspace
 hint1-mode.hint.type=grid
 hint1-mode.hint.grid-area=active-screen
 hint1-mode.hint.active-screen-grid-area-center=screen-center
-hint1-mode.hint.grid-max-row-count=26
-hint1-mode.hint.grid-max-column-count=26
 hint1-mode.hint.grid-cell-width=73
 hint1-mode.hint.grid-cell-height=41
 key-alias.hint1key=a b c d e f g h i j k l m n o p q r s t u v w x y z

diff --git a/src/main/java/mousemaster/ConfigurationParser.java b/src/main/java/mousemaster/ConfigurationParser.java
@@ -82,9 +82,10 @@ private static Map<String, Property<?>> defaultPropertyByName() {
                 .swallowHintEndKeyPress(true)
                 .savePositionAfterSelection(false);
         HintMeshType.HintMeshTypeBuilder hintMeshTypeBuilder = hintMesh.type();
+        // On a 1920x1080 screen 73x41 cell size can accommodate up to 26x26 hints.
         hintMeshTypeBuilder.type(HintMeshType.HintMeshTypeType.GRID)
-                           .gridMaxRowCount(26)
-                           .gridMaxColumnCount(26)
+                           .gridMaxRowCount(100)
+                           .gridMaxColumnCount(100)
                            .gridCellWidth(73)
                            .gridCellHeight(41);
         HintGridArea.HintGridAreaBuilder hintGridAreaBuilder =