Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add twig-cs-fixer phar #154

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Add twig-cs-fixer phar #154

merged 1 commit into from
Aug 13, 2024

Conversation

VincentLanglet
Copy link
Contributor

@theseer theseer merged commit 7dfc4e6 into phar-io:master Aug 13, 2024
@theseer
Copy link
Member

theseer commented Aug 13, 2024

I merged this and deployed the updated repo data file.

To make your phar work with phive though, the public key DEBB71EDE9601234 uploaded to keys.openpgp.org needs to be verified.

@VincentLanglet
Copy link
Contributor Author

To make your phar work with phive though, the public key DEBB71EDE9601234 uploaded to keys.openpgp.org needs to be verified.

How do I do this ?

@theseer
Copy link
Member

theseer commented Aug 13, 2024

GPG Keys usually contain one or more UID entries, identifying entities. For privacy reasons, keys.opengpg.org is stripping them by default until a confirmation is received.

Assuming you used https://keys.openpgp.org/upload to upload it, they will send a confirmation request mail to every UID email listed. This is used as a) proof-of-ownership and b) confirmation to have the respective UID / email be published.

Without a UID though, the key is basically useless: It only proofs someone signed it and nobody tampered with it since then. But as we have no idea who that might be, this doesn't really help ;)

@theseer
Copy link
Member

theseer commented Aug 13, 2024

I have no idea how to add a confirmation in case you didn't get said email(s). Maybe their FAQ helps in that case. We do not have anything to do with that ;)

@thePanz
Copy link

thePanz commented Aug 13, 2024

I can confirm that manually importing the phar from phive results in an error.

There is an additional warning about somehing with the GPG key missing the "UID"

@theseer
Copy link
Member

theseer commented Aug 13, 2024

That's exactly the problem I pointed out :)

@VincentLanglet
Copy link
Contributor Author

I sign with the github noreply adress... Didn't know about this.

I'm working on a fix VincentLanglet/Twig-CS-Fixer#299

@VincentLanglet
Copy link
Contributor Author

I can confirm that manually importing the phar from phive results in an error.

There is an additional warning about somehing with the GPG key missing the "UID"

Should be better with the new version https://github.com/VincentLanglet/Twig-CS-Fixer/releases/tag/3.0.1 @thePanz

@VincentLanglet VincentLanglet deleted the patch-1 branch August 13, 2024 16:37
@thePanz
Copy link

thePanz commented Aug 14, 2024

@VincentLanglet I can confirm that running phive install https://github.com/VincentLanglet/Twig-CS-Fixer/releases/download/3.0.1/twig-cs-fixer.phar properly handles the GPG key now 👍

Minor information:

I was initially not able to install the phar using the alias twig-cs-fixer, as shown below:

$ phive install twig-cs-fixer

Phive 0.15.2 - Copyright (C) 2015-2024 by Arne Blankerts, Sebastian Heuer and Contributors
[ERROR]    Could not resolve requested PHAR twig-cs-fixer

It required to run phive update-repository-list first.

Not sure if such update is automatic or scheduled by phive

@theseer
Copy link
Member

theseer commented Aug 14, 2024

Not sure if such update is automatic or scheduled by phive

Phive will keep a downloaded copy - in case one exists - for a max of 7 days before automagically trying to get a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants