Skip to content

Commit

Permalink
Prefer "PhET-iO Type" to "IO Type", phetsims/phet-io#1972
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed Jan 3, 2024
1 parent bb20ac8 commit 222931c
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
6 changes: 5 additions & 1 deletion eslint/rules/bad-text.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,15 @@ module.exports = function( context ) {
'PhET-iO element', // use "phet-io element" or "PhET-iO Element" https://github.com/phetsims/phet-io/issues/1968
'Phet-iO',
{ id: 'IO type', regex: /\bIO type/ }, // https://github.com/phetsims/chipper/issues/977
// prefer IO Type name , https://github.com/phetsims/phet-io/issues/1972
// prefer PhET-iO Type name , https://github.com/phetsims/phet-io/issues/1972
'IO Typename',
'IO TypeName',
'IO Type Name',

// prefer PhET-iO Type (public name) or IOType (class name) https://github.com/phetsims/phet-io/issues/1972
'IO Type',
' IO type',

'@return ',

// see https://thenewstack.io/words-matter-finally-tech-looks-at-removing-exclusionary-language/ and
Expand Down
2 changes: 1 addition & 1 deletion js/phet-io/phetioCompareAPIs.js
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@

visit( [], referenceAPI.phetioElements, proposedAPI.phetioElements, false );

// Check for: missing IO Types, missing methods, or differing parameter types or return types
// Check for: missing IOTypes, missing methods, or differing parameter types or return types
for ( const typeName in referenceAPI.phetioTypes ) {
if ( referenceAPI.phetioTypes.hasOwnProperty( typeName ) ) {

Expand Down
4 changes: 2 additions & 2 deletions js/phet-io/phetioCompareAPIsTests.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const DEFAULT_API = {
phetioFullAPI: true,
phetioTypes: {
ObjectIO: {
documentation: 'The root of the IO Type hierarchy',
documentation: 'The root of the PhET-iO Type hierarchy',
events: [],
metadataDefaults: {
phetioArchetypePhetioID: null,
Expand Down Expand Up @@ -65,7 +65,7 @@ qunit.test( 'basics', assert => {
phetioElements: {
phetioEngine: {
_metadata: {
phetioDocumentation: 'Central point for PhET-iO interoperability. Please see the IO Type Documentation for API details.',
phetioDocumentation: 'Central point for PhET-iO interoperability. Please see the PhET-iO Type Documentation for API details.',
phetioEventType: 'MODEL',
phetioState: false,
phetioTypeName: 'ObjectIO'
Expand Down

0 comments on commit 222931c

Please sign in to comment.