Skip to content

Commit

Permalink
use console.log for non-errors, phetsims/aqua#234 phetsims/perennial#431
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed Feb 12, 2025
1 parent 4dd172b commit 3d70302
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion js/grunt/tasks/compare-phet-io-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const needsTranspile = isOptionKeyProvided( 'transpile' ) ? getOption( 'transpil
}
const ok = await phetioCompareAPISets( sims, proposedAPIs, options );
if ( !ok ) {
console.error( 'PhET-iO API comparison failed' );
console.log( 'PhET-iO API comparison failed' );
process.exit( 1 );
}

Expand Down
2 changes: 1 addition & 1 deletion js/grunt/tasks/lint-all.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const lintAllPromise = ( async () => {

// Output results on errors.
if ( !lintSuccess ) {
console.error( 'Lint failed' );
console.log( 'Lint failed' );
process.exit( 1 );
}
else {
Expand Down
12 changes: 6 additions & 6 deletions js/phet-io/phetioCompareAPISets.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,16 @@ export default async ( repos: string[], proposedAPIs: PhetioAPIs, providedOption

if ( comparisonData.breakingProblems.length ) {
ok = false;
console.error( `${repo} BREAKING PROBLEMS` );
console.error( comparisonData.breakingProblems.join( '\n' ) );
console.error( '\n' );
console.log( `${repo} BREAKING PROBLEMS` );
console.log( comparisonData.breakingProblems.join( '\n' ) );
console.log( '\n' );
}

if ( comparisonData.designedProblems.length ) {
ok = false;
console.error( `${repo} DESIGN PROBLEMS` );
console.error( comparisonData.designedProblems.join( '\n' ) );
console.error( '\n' );
console.log( `${repo} DESIGN PROBLEMS` );
console.log( comparisonData.designedProblems.join( '\n' ) );
console.log( '\n' );
}

if ( options.delta ) {
Expand Down

0 comments on commit 3d70302

Please sign in to comment.