Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed Nov 26, 2024
1 parent ea87173 commit 88e5372
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion js/browser-and-node/isInitialStateCompatible.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ function areCompatible( groundTruthValue: IntentionalAny, testValue: Intentional
}

// The old array must have at least as many items as the new array
// TODO: Hard code something for validValues for supporting sets? https://github.com/phetsims/phet-io/issues/1951
// TODO: Hard code something for validValues for supporting sets? https://github.com/phetsims/phet-io/issues/1999
// key === 'validValues' -> treat as set
if ( testValue.length !== groundTruthValue.length ) {
return false;
Expand Down
4 changes: 2 additions & 2 deletions js/browser-and-node/phetioCompareAPIs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -340,8 +340,8 @@ const phetioCompareAPIs = ( referenceAPI: PhetioAPI, proposedAPI: PhetioAPI, _:

// Check for: missing IOTypes, missing methods, or differing parameter types or return types
for ( const typeName in referenceAPI.phetioTypes ) {
// TODO: We need a notion of phetioDesigned for Type comparison. https://github.com/phetsims/phet-io/issues/1951
// TODO: add comparison for stateSchema https://github.com/phetsims/phet-io/issues/1951
// TODO: We need a notion of phetioDesigned for Type comparison. https://github.com/phetsims/phet-io/issues/1999
// TODO: add comparison for stateSchema https://github.com/phetsims/phet-io/issues/1999

if ( referenceAPI.phetioTypes.hasOwnProperty( typeName ) ) {

Expand Down

0 comments on commit 88e5372

Please sign in to comment.