Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly extract decision when used with prefix #54

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DrakaSAN
Copy link

@DrakaSAN DrakaSAN commented Jul 5, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

When using a prefix, the TOC generation was failing since the number detection was failing. Update the number detection to account for the prefix.
The TOC generation was using the filename to create the title, instead, do the same thing as the status listing and open the file to extract the title from inside the ADR.

  • What is the current behavior? (You can also link to an open issue here)

TOC generator is using getNumberLength to find where the number is. This function is taking the first part of the name without taking a potential prefix into account, which may mean the function returns part of the prefix instead of the number.

TOC generator is using the filename to generate the title of the ADR.

  • What is the new behavior (if this is a feature change)?

Extract the first part of the filename after removing the prefix to extract the number.

Copy ListGenerateBuilder and extract the ADR title.

  • Other information:

Functionally tested successfully on a small test project, but lacking examples to ensure it didn't break anything else.
Unit test are currently failing and needs to be updated before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant