Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non-NULL assertion to zend_get_gc_buffer_add_obj() #17671

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Add non-NULL assertion to zend_get_gc_buffer_add_obj() #17671

merged 1 commit into from
Feb 2, 2025

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Feb 2, 2025

This would've saved me time when fixing the nightly failure in Laravel [1].

[1] e306a2e

@nielsdos nielsdos marked this pull request as ready for review February 2, 2025 15:08
@nielsdos
Add non-NULL assertion to zend_get_gc_buffer_add_obj()
7e680c0 
This would've saved me time when fixing the nightly failure in Laravel [1].

[1] e306a2e
@cmb69 cmb69 removed the ABI break label Feb 2, 2025
arnaud-lb
arnaud-lb approved these changes Feb 2, 2025
View reviewed changes
Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nielsdos nielsdos merged commit 50ed7b5 into php:master Feb 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-lb arnaud-lb arnaud-lb approved these changes

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nielsdos @arnaud-lb @cmb69