Ticket #1157: support specific filenames as trigger for Shell. #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veewee
reviewed
Feb 26, 2025
| @@ -59,7 +61,12 @@ public function canRunInContext(ContextInterface $context): bool | |||
| public function run(ContextInterface $context): TaskResultInterface | |||
| { | |||
| $config = $this->getConfig()->getOptions(); | |||
| $files = $context->getFiles()->extensions($config['triggered_by']); | |||
| $files = new FilesCollection( | |||
There was a problem hiding this comment.
$files isn't really being used anywhere.
Instead of building the list of files, it might make more sense to count() the amount of files in either trigger.
That way we don't have to do all these lookups all of the time.
| @@ -27,6 +27,7 @@ public function provideConfigurableOptions(): iterable | |||
| [ | |||
| 'scripts' => [], | |||
| 'triggered_by' => ['php'], | |||
| 'triggered_by_filenames' => [], | |||
There was a problem hiding this comment.
We'll also need a test-case that covers how the task behaves on the newly added configuration.
| @@ -50,10 +50,12 @@ protected static function sharedOptionsResolver(): OptionsResolver | |||
| $resolver = new OptionsResolver(); | |||
| $resolver->setDefaults([ | |||
| 'triggered_by' => [], | |||
| 'triggered_by_filenames' => [], | |||
There was a problem hiding this comment.
not sure why this one is altered? It's not being used anywhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Question, I would like to be able to specify a pathname in the filename. This fails now because the pattern is checked against the filename without a path. How to fix?
New Task Checklist:
run()method readable?run()method using the configuration correctly?